Skip to content

Conversation

@southp
Copy link

@southp southp commented Dec 23, 2025

This PR closes #2216 by adding installation instructions using vim-plug. Props to @achille-martin for originally documenting how the full Lua version can be done.

@soifou
Copy link
Collaborator

soifou commented Dec 23, 2025

Thanks for the PR! Here are some insights:

  • This PR appears to resolve Improvement: add installation instructions for vim-plug #2216, you might want to take a look at that issue for inspiration. Then reference and close it in your commit message body.
  • It would be helpful to clarify that the blink.cmp configuration shown here uses the default settings. You could mention this explicitly or comment them out in the example to make that clear.
  • The sentence "config fetching the pre-built binary as the post-installation action" is a bit unclear. Consider rephrasing it to something like: "using a release tag to fetch the pre-built binary after installation" (similar to the lazy.nvim section).

* Link to the relevant issue saghen#2216 from this particular commit message.
* Clarify the configuration is the same one from the lazy.vim section.
* Reuse the same explanation to the post-installation actions
* Incorporate both the VimScript version and the Lua version so users can just copy & paste them easier.
@southp
Copy link
Author

southp commented Dec 24, 2025

Thanks for the great feedback, @soifou . I wasn't aware of #2216. I've addressed your feedback in 423c21e:

Reading #2216, I realized that the way I originally put it was quite inconvenient since users would need to figure out where to put the code. So I chose to include both VimScript and Lua versions that are ready for copying&pasting. I'm a bit concerning that it might be too verbose, though.

When you have some time, could you help me take another look? I'd be grateful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: add installation instructions for vim-plug

2 participants